[CODE] Buffer over-read in DrawLightmappedGeneric_DX9_Internal()

[z33ky]

Describe the bug

My compiler detected a buffer over-read stemming from lightmappedgeneric_dx9_helper.cpp:1571. The called method SetPixelShaderConstant() attempts to read 4 floats from the passed pointer, which is in fact only a singular float.

Expected behavior

No buffer over-read.

---

[z33ky]

Assuming writing the same float 4 times is desired, this is a possible fix:

diff --git a/sp/src/materialsystem/stdshaders/lightmappedgeneric_dx9_helper.cpp b/sp/src/materialsystem/stdshaders/lightmappedgeneric_dx9_helper.cpp
index b2a8ddcc..44db3df7 100644
--- a/sp/src/materialsystem/stdshaders/lightmappedgeneric_dx9_helper.cpp
+++ b/sp/src/materialsystem/stdshaders/lightmappedgeneric_dx9_helper.cpp
@@ -1566,19 +1566,9 @@ void DrawLightmappedGeneric_DX9_Internal(CBaseVSShader *pShader, IMaterialVar**
 			// Doing it here in the shader itself allows us to retain other properties, like FANCY_BLENDING.
 			else
 			{
-				// m_SemiStaticCmdsOut wasn't being sent correctly, so we have to assign this to the API directly
-				float editorBlend = bEditorBlend ? 1.0f : 0.0f;
-				pContextData->m_SemiStaticCmdsOut.SetPixelShaderConstant( 21, &editorBlend, 1 );
-				/*
-				if (bEditorBlend)
-				{
-					pContextData->m_SemiStaticCmdsOut.SetPixelShaderConstant( 35, 1.0f );
-				}
-				else
-				{
-					pContextData->m_SemiStaticCmdsOut.SetPixelShaderConstant( 35, 0.0f );
-				}
-				*/
+				const static float editorBlend[4]  = { 1.0f, 1.0f, 1.0f, 1.0f },
+				                   regularBlend[4] = { 0.0f, 0.0f, 0.0f, 0.0f };
+				pContextData->m_SemiStaticCmdsOut.SetPixelShaderConstant( 21, bEditorBlend ? editorBlend : regularBlend, 1 );
 			}
 #endif