Skip to content

[CODE] vgui_controls library doesn't compile when included outside of client.dll #228

@Blixibon

Description

@Blixibon

Describe the bug

vgui_controls.lib fails to compile when using a custom project which integrates it because it looks for g_bUsingCustomHudAnimations, a value extern'd from the client DLL.

Steps to reproduce

Steps to reproduce the behavior:

  1. Use vgui_controls.lib in a non-client.dll project
  2. Attempt to compile
  3. error LNK2001: unresolved external symbol "bool g_bUsingCustomHudAnimations"

Expected behavior

vgui_controls.lib integration should be supported on any project, not just the client DLL.


Additional context

This has manifested with users trying to integrate the new Gamepad UI project into Mapbase mods, although other, older projects integrate vgui_controls.lib outside of the client as well.

This can easily be fixed by just moving g_bUsingCustomHudAnimations to vgui_controls and making the client look for it instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions