Better circumstantial criteria for followup responses#275
Merged
Blixibon merged 1 commit intoFeb 4, 2024
Merged
Conversation
Blixibon
force-pushed
the
mapbase/feature/response-followup-criteria-expansion
branch
from
b2f9a5f to
70a4304
Compare
Blixibon
force-pushed
the
mapbase/feature/response-followup-criteria-expansion
branch
from
70a4304 to
4adab15
Compare
1upD
reviewed
Jan 14, 2024
| { | ||
| CAI_AllySpeechManager * pSpeechManager = GetAllySpeechManager(); | ||
| ConceptInfo_t * pInfo = pSpeechManager->GetConceptInfo( concept ); | ||
| ConceptCategory_t category = SPEECH_PRIORITY; // Must be SPEECH_PRIORITY to get around semaphore |
There was a problem hiding this comment.
Why do followups get around the semaphore?
There was a problem hiding this comment.
I can see below that if the follow up specifically targets this NPC, it ignores the semaphore. That makes sense. I wonder if there would ever be cases where designers would not want this to be the case? Like low priority followup responses
1upD
approved these changes
Jan 14, 2024
1upD
left a comment
1upD
left a comment
There was a problem hiding this comment.
I left a comment but it was just a speculative question, this looks good to me
Blixibon
deleted the
mapbase/feature/response-followup-criteria-expansion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following criteria to followup responses:
dist_from_issuer— The distance to the issuer of the original response. This already existed onanytype responses, but it will now exist for all followups.is_speaking— Whether or not the person speaking the followup is already speaking.followup_allowed_to_speak— Whether or not the speaker's AI would allow this followup to play as a regular response concept. This includes whether the speaker is already speaking.followup_target_type— The method in which this speaker was selected for a followup response (i.e. whether it was specifically targeting the NPC, whether it was dispatched to all NPCs, or whether it was dispatched to one of any NPCs)These criteria are meant to provide better control over when followups play in relation to HL2's existing speech AI without restricting the behavior that has existed since they were added.
Note that
followup_allowed_to_speakcurrently only applies to entities derived fromCAI_PlayerAlly.PR Checklist
developbranch OR targets another branch with a specific goal in mind