This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Bumped demo and wearable demo up to beta.2#332
Merged
Conversation
Contributor
Author
|
Note: Don't merge until beta.2 is actually available for download, Maven, etc. This is why tests are failing |
Contributor
Author
|
Tests are failing because of LOST in the Android Wearable app Related to mapbox/mapbox-java#401? I'm not sure what to manipulate. Little guidance @tobrun or @zugaldia ? |
|
This should do the job: // Mapbox Maps SDK
compile ('com.mapbox.mapboxsdk:mapbox-android-sdk:5.1.0-beta.2@aar') {
transitive = true
exclude module: 'lost'
exclude module: 'mapbox-java-geojson'
exclude module: 'mapbox-android-telemetry'
} |
Member
|
Why are those exclusions needed on the wearable module, but not in the mobile app? |
Contributor
Author
Member
|
@langsmith Looks like you're hitting mapbox/mapbox-gl-native#8999. |
Contributor
Author
|
Thanks @zugaldia |
zugaldia
approved these changes
May 18, 2017
zugaldia
suggested changes
May 18, 2017
Member
zugaldia
left a comment
There was a problem hiding this comment.
My bad, I only checked the code and I didn't notice CI was complaining. Let's hold on merging for now.
Contributor
Author
|
@zugaldia , with the LOST fix, this PR's tests now pass. Approve so that I can merge? |
zugaldia
approved these changes
May 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Updated gradle dependency lines