Skip to content

Handle alternate locale names, long locale names #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mapmeld wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Handle alternate locale names, long locale names #67

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e85685
use synonyms to accept zh-HK
mapmeld Jul 26, 2025
5c1f5d9
include HK example
mapmeld Jul 26, 2025
a9b8f5e
rename ALT_LOCALES
mapmeld Jul 26, 2025
055f411
use recursion to reduce long locales by piece
mapmeld Jul 26, 2025
64fd04c
add locales, change recursive calls to a while loop
mapmeld Aug 5, 2025
930ae1b
add tests
mapmeld Aug 5, 2025
1664478
remove change to browserLanguagefn
mapmeld Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename ALT_LOCALES
  • Loading branch information
@mapmeld
mapmeld committed Jul 26, 2025
commit a9b8f5e5f1a97bfbec294c253f1dbf9772c6607d
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* accept values from common locale selectors */
const SYNONYMS = {
const ALT_LOCALES = {
'zh-CN': 'zh-Hans',
'zh-Hans-CN': 'zh-Hans',
'zh-HK': 'zh-Hant',
Expand Down Expand Up @@ -125,7 +125,7 @@ function findStreetsSource(style) {
* @returns {object} the modified style
*/
MapboxLanguage.prototype.setLanguage = function (style, language) {
language = SYNONYMS[language] || language;
language = ALT_LOCALES[language] || language;
if (this.supportedLanguages.indexOf(language) < 0) {
throw new Error(`Language ${ language } is not supported`);
}
Expand Down Expand Up @@ -156,7 +156,7 @@ MapboxLanguage.prototype._initialStyleUpdate = function () {

function browserLanguage(supportedLanguages) {
let language = navigator.languages ? navigator.languages[0] : (navigator.language || navigator.userLanguage);
language = SYNONYMS[language] || language;
language = ALT_LOCALES[language] || language;
const parts = language && language.split('-');
let languageCode = language;
if (parts.length > 1) {
Expand Down