This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Expose LocationUpdate builder and immediate location animation when resuming the map#604
Merged
Merged
Conversation
LukasPaczos
force-pushed
the
lp-immediate-location-animation
branch
2 times, most recently
from
10ea470 to
5eb0803
Compare
kiryldz
reviewed
Oct 21, 2020
kiryldz
reviewed
Oct 21, 2020
| * cutting out the time interpolation delay. | ||
| * @deprecated use {@link #forceLocationUpdate(LocationUpdate)} instead | ||
| */ | ||
| @Deprecated |
Contributor
There was a problem hiding this comment.
Perhaps do not see whole picture but why is logic changed for already deprecated method?
IMHO it should have worked the same way it did before while new non-deprecated method is introduced.
Author
There was a problem hiding this comment.
I moved the calculation of duration out of the animator coordinator to maintain compatibility since the coordinator now accepts the duration as an argument.
…esuming the map With this update, we're consolidating all options available to developers when they are driving their own location updates. This deprecates the lookAhead flag and in return exposes an option to completely control the animation duration of the puck and camera location transitions. This can be used for the lookAhead animation, or for situational change in the animation duration, for example, if an immediate transition is necessary instead of a smooth one.
LukasPaczos
force-pushed
the
lp-immediate-location-animation
branch
from
5eb0803 to
3d2fa43
Compare
kiryldz
approved these changes
Oct 22, 2020
Contributor
kiryldz
left a comment
kiryldz
left a comment
There was a problem hiding this comment.
Code LGTM assuming it's tested in some real navigation case and works as expected.
Author
|
I updated the OP to reflect all of the changes that this PR brings. I also tested a local snapshot with our drive testing app and the instant resume feature as well as backward compatibility look good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this update, we're consolidating all options available to developers when they are driving their own location updates. This deprecates the
lookAheadflag and in return exposes an option to completely control the animation duration of the puck and camera location transitions. This can be used for thelookAheadanimation, or for situational change in the animation duration, for example, if an immediate transition is necessary instead of a smooth one.This also makes the transition to the last location instantaneous when the component is re-enabled or the map is resumed, instead of smoothly trying to catch-up. This prevents the puck from gliding over buildings and cutting corners to synchronize with the current location.
/cc @mapbox/navigation-android