This repository was archived by the owner on Jun 21, 2023. It is now read-only.
[android] - trigger exception when onCreate is not called#626
Merged
Conversation
tobrun
force-pushed
the
tvn-add-exception
branch
from
497796a to
c18bef6
Compare
tobrun
force-pushed
the
tvn-add-exception
branch
from
c18bef6 to
3f6cee9
Compare
tobrun
force-pushed
the
tvn-add-exception
branch
from
3f6cee9 to
c69c55f
Compare
kiryldz
reviewed
Feb 9, 2021
kiryldz
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a flag and exception to validate onCreate was correctly called. OnStart has to be called to be able to render a map, throwing from that method looked like the most valid code path to validate if OnCreate was called.