Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Simplify and consolidate Shape sources #10410

@asheemmamoowala

Description

@asheemmamoowala

In #9983 and previous tickets, there has been much discussion over the naming and convention around MGLComputedShapeSource and its related classes.

Previous conversations have centered around:

  • Removing MGLAbstractShapeSource in favor of a single MGLShapeSource that allows providing the shape content in a single call, or via callbacks. #9983(comment)
  • Improving the API interface for MGLComputedShapeSourceDataSource to better indicate that it will not be called on the main thread, and should be implemented with thread safety in mind.1, 2, and 3
  • Simplifying MGLShapeSourceOption, and better align it with the specific options of the shape source being used.

cc @1ec5

Metadata

Metadata

Assignees

No one assigned

    Labels

    SEMVER-MAJORRequires a major release according to Semantic Versioning rulesiOSMapbox Maps SDK for iOSmacOSMapbox Maps SDK for macOSrefactorruntime styling

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions