Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

mbgl::Map::getStyleJSON() should reflect runtime styling changes #7563

@1ec5

Description

@1ec5

mbgl::Map::getStyleJSON() returns the exact string that was originally passed into mbgl::Map::setStyleJSON() or fetched from the style URL, even if the style has been mutated since then using the runtime styling API. It should instead return a serialized representation of the current style, reflecting any changes made using the runtime styling API (and annotations API?).

Ultimately, I think the iOS/macOS SDK should expose an -[MGLStyle JSONDataUsingEncoding:] method that would use mbgl::Map::getStyleJSON() to return the current style. This method would complement the initializers proposed in #6386, make it easier to implement the runtime styling API in React Native Mapbox GL (nitaliano/react-native-mapbox-gl#416), and allow macosapp to save out the results of any runtime styling changes in MapDocument.

/cc @jfirebaugh @frederoni

Metadata

Metadata

Assignees

No one assigned

    Labels

    CoreThe cross-platform C++ core, aka mbglGL JS parityFor feature parity with Mapbox GL JSarchivedArchived because of inactivityfeatureruntime styling

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions