Crash on Android in GeoJsonSource finalize

[quicklywilliam]

I'm seeing a timeout exception on collecting a GeoJsonSource object:

Fatal Exception: java.util.concurrent.TimeoutException: com.mapbox.mapboxsdk.style.sources.GeoJsonSource.finalize() timed out after 10 seconds
       at com.mapbox.mapboxsdk.style.sources.GeoJsonSource.finalize(GeoJsonSource.java)
       at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:191)
       at java.lang.Daemons$FinalizerDaemon.run(Daemons.java:174)
       at java.lang.Thread.run(Thread.java:818)

Here's how we are instantiating the only GeoJsonSource we add to the map:

Feature tripFeature = Feature.fromGeometry(LineString.fromCoordinates(points));
GeoJsonSource tripLineSource = new GeoJsonSource(tripFeatureSourceIdentifier, FeatureCollection.fromFeatures(new Feature[] { tripFeature }));
map.addSource(tripLineSource);

This is on the 4.2.2 release. Does not reproduce every time, but we're getting multiple reports of this on our production app release.

[tobrun]

I'm only seeing a default destructor for GeoJsonSource which is called as result of GeoJsonSource.finalize(). Not sure how this could result in locking and timing out.
Do you have any ideas on this @jfirebaugh?

cc @ivovandongen

[jfirebaugh]

@quicklywilliam Do you ever remove that source from the map?

[lamhuynh96]

This error usually happens when I add some Fill layers from GeoJsonSources to my 1st map style and then switch to 2nd style. To keep these layers, I remove sources and layers before changing style and add them again after that. Everything seems to be fine, but after switching to 2nd style, if I remove these layers and its sources, then add the others and repeating adding and removing them twice or third times, this time out exception appears.

[tobrun]

Thank you for the detailed instructions. I'm working on reproducing this crash locally.

[quicklywilliam]

Sorry for the late reply. To answer your question, I do indeed remove the source but I don't switch styles like @lamhuynh96 mentioned. As a possible work around I've started keeping the source on the map and instead modifying the underlying feature. I'll report back if that makes the crashes go away.

[ivovandongen]

@quicklywilliam / @lamhuynh96 Would you be able to test if #8298 fixes your issue? It's in the latest snapshot.

[quicklywilliam]

@ivovandongen I cannot currently reproduce the issue in-house. I can take out our work-around and see what happens with #8298 once it is in a production-stable build…

[lamhuynh96]

@ivovandongen Is 5.0.0-SNAPSHOT the latest? I just move from 4.2.2 to this snapshot, try these steps above and the time-out exception seems not to be disappeared.

http://i.giphy.com/l4FGxJbTuTp5Sh9kc.gif

This is the log from my app.
errorlog.txt

[ivovandongen]

@lamhuynh96

Is 5.0.0-SNAPSHOT the latest

If you have a recent one, then yes.

Would you be able create a small example app that reproduces this error? We haven't been able to reproduce this locally.

[lamhuynh96]

@ivovandongen this is link to my app: https://gitlab.com/lamhuynh96/BanDoThuDuc. Hope you can find something useful to reproduce this error.

[cammace]

Unfortunately I wasn't able to reproduce the issue described here. The code I used to reproduce the issue can be viewed here. Note that I am only adding the source and layer if they are null.

[Guardiola31337]

@lamhuynh96 i was able to reproduce the crash with beta.2 (using your app and following the steps you mentioned).
It's now resolved by #8298 (I followed same steps with the new SNAPSHOT and I wasn't able to reproduce it again).