[android] Integration of the new events library by Guardiola31337 · Pull Request #10999 · mapbox/mapbox-gl-native

Guardiola31337 · 2018-01-23T19:45:15Z

Integrates the new events library

cc @electrostat @tobrun @osana @zugaldia @boundsj

zugaldia · 2018-01-23T20:11:02Z

@Guardiola31337 @electrostat Parallel to this PR, @osana is working on integrating the MAS 3.x on #10920 and I believe she's encountering some (old) telemetry integration issues. Would you recommend working on MAS 3.x integration as branched work from this PR, or should we continue with the current approach on #10920?

osana · 2018-01-23T20:19:32Z

@zugaldia @electrostat @Guardiola31337 @cammace @tobrun

Turned out that the issue I had was related to my JNI code but the error message said that it was not finding some class related to GoogleLocationEngine. I should be good for now. If needed I will cherry-pick my change into the a child branch of this one.

Guardiola31337 · 2018-01-23T20:22:10Z

Would you recommend working on MAS 3.x integration as branched work from this PR, or should we continue with the current approach on #10920?

So far, we needed to create MathUtils (not available in the old library anymore) and used it in CameraPosition and MapGestureDetector.

So, whatever is easier for you ¯\_(ツ)_/¯

tobrun · 2018-01-24T14:15:06Z

  private Boolean connected;
  private LocationEngine locationEngine;
+  @SuppressLint("StaticFieldLeak")
+  private static MapboxTelemetry telemetry;


any background on why this should be static?

tobrun · 2018-01-24T14:16:36Z

+          // TODO transform.getZoom() may cause a NullPointerException
+          MapState twoFingerTap = new MapState((float) latLng.getLatitude(), (float) latLng.getLongitude(), (float)
+            transform.getZoom());
+          twoFingerTap.setGesture("TwoFingerTap");


do we have any gesture constants? eg. for TwoFingerTap etc.

tobrun · 2018-01-24T14:17:37Z

-            MapboxEvent.GESTURE_TWO_FINGER_SINGLETAP, transform));
+          MapEventFactory mapEventFactory = new MapEventFactory();
+          LatLng latLng = projection.fromScreenLocation(new PointF(event.getX(), event.getY()));
+          // TODO transform.getZoom() may cause a NullPointerException


on top of this todo, would it be possible hardening add same checks as with #10959 ?

tobrun · 2018-01-24T14:21:39Z

+          MapEventFactory mapEventFactory = new MapEventFactory();
+          LatLng latLng = projection.fromScreenLocation(new PointF(event.getX(), event.getY()));
+          // TODO transform.getZoom() may cause a NullPointerException
+          MapState twoFingerTap = new MapState((float) latLng.getLatitude(), (float) latLng.getLongitude(), (float)


Would it makes sense changing MapState to double instead of float?

Guardiola31337 · 2018-01-29T18:08:28Z

      }

      ConnectivityReceiver.instance(appContext);
+      Timber.d("instance: connectivity receiver started");


How adding a log solves a JNI bug?
In any case, we should remove these logs before merging because they'd clutter Logcat unnecessarily.

Guardiola31337 · 2018-01-29T18:13:28Z

@tobrun
All the comments are addressed in https://github.com/mapbox/mapbox-gl-native/tree/pg-fix-events-lib-integration-comments, right now build is failing because changes depend on mapbox/mapbox-events-android#60 and mapbox/mapbox-events-android#61 when those get merged, we should cherry-pick 0dd1937 in and this PR should be ready to go 🚀

cc @electrostat

electrostat

Looks Good.
@tobrun give it a once over, if you can. Then I think we are good to go on this one.

zugaldia

Some comments to the PR, non-blocking, can be addressed in follow up tickets if necessary.

zugaldia · 2018-01-30T01:11:13Z

@@ -0,0 +1,79 @@
+package com.mapbox.mapboxsdk.utils;
+
+// TODO Remove this class if we finally include it within MAS 3.x (GeoJSON)


Remove or ticket.

@electrostat

Ticketed

This should be ticketed in this repo 👉 https://github.com/mapbox/mapbox-gl-native/issues

Follow up ticket 👉 #11182

zugaldia · 2018-01-30T01:11:23Z

   *
   * @return the location engine configured
   */
+  // TODO Do we need to expose this?


Remove or ticket.

@electrostat

Ticketed

This should be ticketed in this repo 👉 https://github.com/mapbox/mapbox-gl-native/issues

zugaldia · 2018-01-30T01:13:57Z

    implementation dependenciesList.supportDesign

-    implementation dependenciesList.lost
+    // implementation dependenciesList.lost


Duplicated line.

zugaldia · 2018-01-30T01:15:25Z


    versions = [
            mapboxServices: '2.2.9',
+            mapboxTelemetryVersion: '3.0.0-SNAPSHOT',


Is it necessary to rely on a SNAPSHOT? If so, upgrading to a stable version needs to be ticketed.

zugaldia · 2018-01-30T01:16:01Z

            supportRecyclerView   : "com.android.support:recyclerview-v7:${versions.supportLib}",

            lost                  : "com.mapzen.android:lost:${versions.lost}",
+            gmsLocation           : 'com.google.android.gms:play-services-location:11.0.4',


We should use ${versions.*} for consistency here too.

zugaldia · 2018-01-30T01:20:58Z

        buildConfigField "String", "GIT_REVISION_SHORT", String.format("\"%s\"", getGitRevision())
+        buildConfigField "String", "MAPBOX_SDK_IDENTIFIER", String.format("\"%s\"", "mapbox-maps-android")
+        buildConfigField "String", "MAPBOX_SDK_VERSION", String.format("\"%s\"", project.VERSION_NAME)
        buildConfigField "String", "MAPBOX_VERSION_STRING", String.format("\"Mapbox/%s\"", project.VERSION_NAME)


Is MAPBOX_VERSION_STRING still being used or was it replaced by MAPBOX_SDK_VERSION?

It's still being used in HTTPRequest 👀

mapbox-gl-native/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/http/HTTPRequest.java

Line 210 in e2a4dff

BuildConfig.MAPBOX_VERSION_STRING,

- current build with JNI bug

- clean-up timbers and test code

tobrun · 2018-02-13T10:02:58Z

can we update this PR with telem beta version and merge this?

…ed methods from math utils class

Guardiola31337 · 2018-02-13T10:15:47Z

can we update this PR with telem beta version and merge this?

bcf3d42 addresses ☝️

I guess that we’re moving forward and we’ll remove MathUtils (#10999 (comment)) later, when mapbox/mapbox-java#719 lands and a new beta of MAS 3.0 is available, right?

Guardiola31337 · 2018-02-13T10:39:22Z

I guess that we’re moving forward and we’ll remove MathUtils (#10999 (comment)) later, when mapbox/mapbox-java#719 lands and a new beta of MAS 3.0 is available, right?

Follow up ticket 👉 #11182

* [android] integration of the new events library * JNI Bug - current build with JNI bug * fix #10999 comments * Clean-up - clean-up timbers and test code * [android] fix sdk identifier and sdk version * [android] merge from master (MAS 3.0) * [android] bump events lib version to 3.0.0-beta.1 and remove never used methods from math utils class

Guardiola31337 added Android Mapbox Maps SDK for Android telemetry Integration with Mapbox Telemetry libraries ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Jan 23, 2018

Guardiola31337 added this to the android-v6.0.0 milestone Jan 23, 2018

Guardiola31337 self-assigned this Jan 23, 2018

Guardiola31337 requested review from electrostat and tobrun January 23, 2018 19:45

Guardiola31337 force-pushed the pg-events-lib-integration branch from 6532a4e to a30a81b Compare January 23, 2018 19:53

electrostat mentioned this pull request Jan 23, 2018

Integrate New Telemetry Library #10986

Closed

tobrun reviewed Jan 24, 2018

View reviewed changes

Guardiola31337 pushed a commit that referenced this pull request Jan 29, 2018

fix #10999 comments

0dd1937

Guardiola31337 commented Jan 29, 2018

View reviewed changes

Guardiola31337 pushed a commit that referenced this pull request Jan 29, 2018

fix #10999 comments

a761198

Guardiola31337 force-pushed the pg-events-lib-integration branch from 88bc8f4 to 0d5aac4 Compare January 29, 2018 22:47

Guardiola31337 pushed a commit that referenced this pull request Jan 29, 2018

fix #10999 comments

84eef24

electrostat approved these changes Jan 29, 2018

View reviewed changes

zugaldia reviewed Jan 30, 2018

View reviewed changes

Guardiola31337 mentioned this pull request Feb 5, 2018

fix events integration comments + ToDos #11085

Closed

Guardiola31337 force-pushed the pg-events-lib-integration branch from 5b6fde7 to 35e618c Compare February 8, 2018 23:05

Guardiola31337 pushed a commit that referenced this pull request Feb 8, 2018

fix #10999 comments

9f1612f

Guardiola31337 and others added 6 commits February 12, 2018 10:50

[android] integration of the new events library

402802f

JNI Bug

002d6a2

- current build with JNI bug

Clean-up

bf354fe

- clean-up timbers and test code

fix #10999 comments

03a077c

[android] fix sdk identifier and sdk version

3ced76f

[android] merge from master (MAS 3.0)

867ed80

Guardiola31337 force-pushed the pg-events-lib-integration branch from 35e618c to 867ed80 Compare February 12, 2018 10:20

[android] bump events lib version to 3.0.0-beta.1 and remove never us…

bcf3d42

…ed methods from math utils class

Guardiola31337 merged commit 44ca0a5 into master Feb 13, 2018

Guardiola31337 deleted the pg-events-lib-integration branch February 13, 2018 10:31

Guardiola31337 mentioned this pull request Feb 13, 2018

[android] Integration of the new events library (#10999) #11183

Merged

tobrun mentioned this pull request Feb 13, 2018

Release Android v6.0.0-beta.2 #11188

Closed

23 tasks

		@@ -0,0 +1,79 @@
		package com.mapbox.mapboxsdk.utils;

		// TODO Remove this class if we finally include it within MAS 3.x (GeoJSON)

Conversation

Guardiola31337 commented Jan 23, 2018

Uh oh!

zugaldia commented Jan 23, 2018

Uh oh!

osana commented Jan 23, 2018

Uh oh!

Guardiola31337 commented Jan 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Guardiola31337 commented Jan 29, 2018

Uh oh!

electrostat left a comment

Choose a reason for hiding this comment

Uh oh!

zugaldia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobrun commented Feb 13, 2018

Uh oh!

Guardiola31337 commented Feb 13, 2018

Uh oh!

Guardiola31337 commented Feb 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants