This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Handle transition duration of 0ms for symbols#13535
Merged
Conversation
Contributor
Author
|
cc @tobrun |
ansis
approved these changes
Dec 10, 2018
Contributor
Author
|
Actually I convinced myself we don't need to revert the configurable duration, we just need to preserve the logic that does placement at >=300ms intervals even if fading is set to happen faster. I think I was misunderstanding what I was seeing running the repro case in the Android debugger. |
Fixes issue #13506 -- transition duration of 0 would cause symbol flickering.
36f3f8a to
b6a5376
Compare
Contributor
Author
|
Updated this PR to just do the smaller change of handling the "divide by zero" case. The symbol fade duration still inherits from the map's "transition duration", and I verified that if it's set to less than 300ms, collision detection is still rate limited to every 300ms (although the fade duration itself is still shortened). |
Contributor
|
Thanks @ChrisLoer 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #13506.
Small non-zero values worked, but were unexpectedly expensive (because of requiring frequent collision detection)Although this commit reverts the configurable duration, it leaves the "enablePlacementTransitions" flag intact.cc @ansis @tmpsantos @brunoabinader