Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Updates default styles to streets v11, etc.#13585

Merged
julianrex merged 6 commits into
masterfrom
upgrade-default-styles-to-v11
Dec 18, 2018
Merged

Updates default styles to streets v11, etc.#13585
julianrex merged 6 commits into
masterfrom
upgrade-default-styles-to-v11

Conversation

@julianrex
Copy link
Copy Markdown
Contributor

@julianrex julianrex commented Dec 14, 2018 •
edited
Loading

@julianrex julianrex added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold Core The cross-platform C++ core, aka mbgl labels Dec 14, 2018
@julianrex julianrex added this to the release-iowaska milestone Dec 14, 2018
@julianrex julianrex requested a review from 1ec5 as a code owner December 14, 2018 15:48
@julianrex julianrex requested a review from a team December 14, 2018 15:48
fabian-guerra
fabian-guerra reviewed Dec 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update this:

mapbox-gl-native/test/util/mapbox.test.cpp

Lines 95 to 97 in f5337a7

"https://api.mapbox.com/styles/v1/mapbox/streets-v10/sprite?access_token=key&fresh=true.png",
mbgl::util::mapbox::normalizeSpriteURL(util::API_BASE_URL,
"mapbox://sprites/mapbox/streets-v10?fresh=true.png",

1ec5
1ec5 approved these changes Dec 17, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for iOS and macOS. Suggested changelog entry:

  • MGLMapView, MGLShapeOfflineRegion, and MGLTilePyramidOfflineRegion now default to version 11 of the Mapbox Streets style. Similarly, several class properties of MGLStyle, such as MGLStyle.lightStyleURL, have been updated to return URLs to new versions of their respective styles.

@julianrex
Copy link
Copy Markdown
Contributor Author

julianrex commented Dec 17, 2018

Thanks @1ec5!

1ec5
1ec5 reviewed Dec 17, 2018
View reviewed changes
Comment thread test/util/mapbox.test.cpp
@LukasPaczos LukasPaczos removed the Android Mapbox Maps SDK for Android label Dec 17, 2018
@LukasPaczos
Copy link
Copy Markdown
Contributor

LukasPaczos commented Dec 17, 2018

Feel free to merge if all is done on the iOS/macOS side of things. I'm removing the Android label and I'm going to follow up with a separate PR.

@julianrex julianrex changed the title Initial work in updating styles. Updates default styles to streets v11, etc. Dec 17, 2018
@julianrex
Copy link
Copy Markdown
Contributor Author

julianrex commented Dec 18, 2018

/cc @agentpu1011

@julianrex julianrex removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Dec 18, 2018
@1ec5 1ec5 mentioned this pull request Dec 18, 2018
Closed
4 tasks
@captainbarbosa
Copy link
Copy Markdown
Contributor

captainbarbosa commented Dec 18, 2018 •
edited
Loading

Tested on-device, looks good 👍

@julianrex julianrex merged commit 1c7cd24 into master Dec 18, 2018
@julianrex julianrex deleted the upgrade-default-styles-to-v11 branch December 18, 2018 21:00
julianrex added a commit that referenced this pull request Dec 18, 2018
@julianrex
[core, ios, macos] Updates default styles to streets v11, etc. Cherry…
e36e4cf 
… picks 1c7cd24 #13585
@LukasPaczos LukasPaczos mentioned this pull request Dec 19, 2018
Closed
@captainbarbosa captainbarbosa mentioned this pull request Dec 21, 2018
Merged
fabian-guerra pushed a commit that referenced this pull request Jan 7, 2019
@julianrex @fabian-guerra
[core,ios,macos] Re-apply default styles to streets v11, etc. (#13585)
a09c7f4 
# Conflicts:
#	platform/ios/CHANGELOG.md
#	platform/macos/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@1ec5 1ec5 1ec5 approved these changes

@fabian-guerra fabian-guerra fabian-guerra approved these changes

@captainbarbosa captainbarbosa captainbarbosa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Projects

None yet

Milestone

release-iowaska

Development

Successfully merging this pull request may close these issues.

5 participants

@julianrex @LukasPaczos @captainbarbosa @1ec5 @fabian-guerra