Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions include/mbgl/map/map.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,7 @@ class Map : private util::noncopyable {
void renderStill(StillImageCallback callback);

// Triggers a synchronous or asynchronous render.
bool renderSync();

// Nudges transitions one step, possibly notifying of the need for a rerender.
void nudgeTransitions(bool forceRerender);
void renderSync();

// Notifies the Map thread that the state has changed and an update might be necessary.
void update(Update update = Update::Nothing);
Expand Down
4 changes: 1 addition & 3 deletions platform/ios/MGLMapView.mm
Original file line number Diff line number Diff line change
Expand Up @@ -703,11 +703,9 @@ - (void)glkView:(__unused GLKView *)view drawInRect:(__unused CGRect)rect

_mbglMap->setSourceTileCacheSize(cacheSize);

bool needsRerender = _mbglMap->renderSync();
_mbglMap->renderSync();

[self updateUserLocationAnnotationView];

_mbglMap->nudgeTransitions(needsRerender);
}
}

Expand Down
8 changes: 2 additions & 6 deletions src/mbgl/map/map.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void Map::renderStill(StillImageCallback callback) {
FrameData{ view.getFramebufferSize() }, callback);
}

bool Map::renderSync() {
void Map::renderSync() {
if (renderState == RenderState::never) {
view.notifyMapChange(MapChangeWillStartRenderingMap);
}
Expand All @@ -69,13 +69,9 @@ bool Map::renderSync() {
view.notifyMapChange(MapChangeDidFinishRenderingMapFullyRendered);
}

return result.needsRerender;
}

void Map::nudgeTransitions(bool forceRerender) {
if (transform->needsTransition()) {
update(Update(transform->updateTransitions(Clock::now())));
} else if (forceRerender) {
} else if (result.needsRerender) {
update();
}
}
Expand Down