This repository was archived by the owner on Aug 8, 2023. It is now read-only.
fix iOS view sync regression#1904
Merged
Merged
Conversation
Contributor
Author
|
More background: #1813 |
Contributor
|
Sorry for that, I am reverting my revert and adding support for GLFW port. Thank you @incanus! |
…nt view syncing"" This reverts commit 263f9fa.
Contributor
👍 on that. The code in there explicitly creates the |
Contributor
Author
|
👍 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1903 introduced a regression in the improvements from #1125. The addition of
nudgeTransitionswas not related to #1548, but rather happened in b838816 to allow iOS to insert position updates to native views between the GL frame draw and any changes to theTransform, so that the views were in sync with the GL frame.@brunoabinader