This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Remove LatLng::null, vec2::null, and operator bool#4355
Closed
jfirebaugh wants to merge 1 commit into
Closed
Conversation
jfirebaugh
changed the title
jfirebaugh
changed the title
jfirebaugh
changed the title
jfirebaugh
force-pushed
the
non-nan
branch
2 times, most recently
from
7c23545 to
7b05851
Compare
Contributor
|
👍 Glad to see one of the best idioms I learned while learning Rust (together with type traits) in C++! |
| double easting = 0; | ||
|
|
||
| ProjectedMeters(double n = 0, double e = 0) | ||
| ProjectedMeters(double n, double e) |
Contributor
There was a problem hiding this comment.
Shouldn't ProjectedMeters ctor params have the same NaN/infinite checks as in LatLng?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using NaN, 0 or other special values to indicate the lack of a real
LatLngorvec2value, we should useoptional<LatLng>oroptional<vec2>.Refs #3802, #4285.
cc @brunoabinader