This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Include geometry in queryRenderedFeatures results#5066
Merged
Conversation
jfirebaugh
force-pushed
the
query-geometry
branch
3 times, most recently
from
764149d to
4465e99
Compare
jfirebaugh
force-pushed
the
query-geometry
branch
from
4465e99 to
5864c8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another core part of #352.
I disabled several query tests that are failing and need investigation. At least some of them appear to stem from differences in geometry handling between geojson-vt-js and geojson-vt-cpp. However, having invested over a week into this PR now, I would like to move on to something new. @mourner is this something that you could pick up?