This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Allow implicit animation of annotation views#6215
Merged
Merged
Conversation
friedbunny
added
bug
iOS
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @incanus to be potential reviewers. |
Contributor
We really haven't made any recently, and based on my testing, we are 👌 here. |
Contributor
|
Shouldn't we also just get rid of the |
Contributor
|
Yeah, I don’t think we need the override at all. |
Contributor
Author
|
Removed the |
friedbunny
changed the title
friedbunny
force-pushed
the
fb-reanimate-user-dot
branch
from
0420eab to
a39ef54
Compare
friedbunny
force-pushed
the
fb-reanimate-user-dot
branch
from
a39ef54 to
44ff7c4
Compare
Contributor
Author
- Allows the user location annotation to again animate its movements while no tracking mode is enabled.
friedbunny
force-pushed
the
fb-reanimate-user-dot
branch
from
44ff7c4 to
fcee1a8
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were disabling the implicit animation of
positionchanges for annotation views (bb2f627 in #5550), but this meant that UIView animations were also being canceled. Once the user location annotation started inheriting from MGLAnnotationView, this meant that non-tracking changes to the user dot became unanimated.This change shouldn’t affect the sync between map view and annotation views, as we already disable implicit animations when we update their position in -[MGLMapView updateAnnotationViews].
This also removes redundant implicit animation disabling in MGLUserLocationAnnotationView.
@incanus, I could definitely use some help confirming that this doesn’t actually regress any of our annotation view sync/performance improvements. 😁
Fixes #6203.
/cc @1ec5