This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios] specify plist-file for settings bundle#6948
Merged
Merged
Conversation
|
@frederoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @boundsj and @friedbunny to be potential reviewers. |
Contributor
|
Unit tests are failing to compile on iOS (but not macOS, interestingly enough): |
1ec5
approved these changes
Nov 7, 2016
Contributor
1ec5
left a comment
There was a problem hiding this comment.
Did this start with Xcode 8.1 or later?
That must be what introduced the failure.
Feel free to merge once we figure out what’s going on with the iOS unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6947
Did this start with Xcode 8.1 or later?
Root.plist is usually picked up automatically from the settings bundle. Not sure why it doesn't all of a sudden.
@kkaefer 👀