This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Rename MGLGeoJSONSource to MGLShapeSource#7334
Merged
Conversation
boundsj
added
iOS
|
@boundsj, thanks for your PR! By analyzing this pull request, we identified @1ec5, @friedbunny and @incanus to be potential reviewers. |
1ec5
approved these changes
Dec 8, 2016
Contributor
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
A couple stray references to “GeoJSON source”, but otherwise this looks good.
| extern const MGLShapeSourceOption MGLShapeSourceOptionSimplificationTolerance; | ||
|
|
||
| /** | ||
| A GeoJSON source. |
Contributor
There was a problem hiding this comment.
This description is looking increasingly unhelpful.
Contributor
There was a problem hiding this comment.
I rewrote the documentation for each source in #7346.
| - (instancetype)initWithIdentifier:(NSString *)identifier geoJSONData:(NSData *)data options:(nullable NS_DICTIONARY_OF(MGLShapeSourceOption, id) *)options NS_DESIGNATED_INITIALIZER; | ||
|
|
||
| /** | ||
| Returns a GeoJSON source with an identifier, URL, and dictionary of options for |
Contributor
There was a problem hiding this comment.
It’s a shape source now. (Look for occurrences of “GeoJSON source” within this file.)
|
|
||
| /** | ||
| An `NSNumber` object containing a Boolean enabling or disabling clustering. | ||
| If the `features` property contains point features, setting this option to |
Contributor
There was a problem hiding this comment.
While you’re here, features has been replaced by shape.
This was referenced Dec 8, 2016
boundsj
force-pushed
the
boundsj-rename-geojson-source
branch
2 times, most recently
from
b31ee72 to
e9c8570
Compare
boundsj
removed
the
⚠️ DO NOT MERGE
boundsj
force-pushed
the
boundsj-rename-geojson-source
branch
from
e9c8570 to
d39dbc6
Compare
This was referenced Dec 10, 2016
This was referenced Dec 10, 2016
ericrwolfe
added a commit
that referenced
this pull request
Dec 13, 2016
* release-ios-v3.4.0: [ios] Fixed crash on launch in iosapp [ios] Fix iosapp runtime styling examples (#7395) [ios, macos] handle duplicate layer error [core] guard against duplicate layer ids [core] use raii to guard backend deactivation [ios, macos] Override references to property names in property requirements lists (#7391) [ios, macos] Load features into shape source if possible (#7339) [ios, macos] Expanded source documentation [ios, macos] Rename MGLGeoJSONSource to MGLShapeSource (#7334) [ios, macos] Silence -Wc++11-narrowing warning in open gl layer (#7355) [ios, macos] Source-driven attribution (#5999) [ios, macos] renamed raster-hue-rotate # Conflicts: # platform/darwin/src/MGLRasterSource.h # platform/darwin/src/MGLShapeSource.h # platform/darwin/src/MGLSource.h # platform/darwin/src/MGLVectorSource.h
ericrwolfe
added a commit
that referenced
this pull request
Dec 13, 2016
* release-ios-v3.4.0: [ios] Fixed crash on launch in iosapp [ios] Fix iosapp runtime styling examples (#7395) [ios, macos] handle duplicate layer error [core] guard against duplicate layer ids [core] use raii to guard backend deactivation [ios, macos] Override references to property names in property requirements lists (#7391) [ios, macos] Load features into shape source if possible (#7339) [ios, macos] Expanded source documentation [ios, macos] Rename MGLGeoJSONSource to MGLShapeSource (#7334) [ios, macos] Silence -Wc++11-narrowing warning in open gl layer (#7355) [ios, macos] Source-driven attribution (#5999) [ios, macos] renamed raster-hue-rotate
ericrwolfe
added a commit
that referenced
this pull request
Dec 14, 2016
* release-ios-v3.4.0: [ios] Fixed crash on launch in iosapp [ios] Fix iosapp runtime styling examples (#7395) [ios, macos] handle duplicate layer error [core] guard against duplicate layer ids [core] use raii to guard backend deactivation [ios, macos] Override references to property names in property requirements lists (#7391) [ios, macos] Load features into shape source if possible (#7339) [ios, macos] Expanded source documentation [ios, macos] Rename MGLGeoJSONSource to MGLShapeSource (#7334) [ios, macos] Silence -Wc++11-narrowing warning in open gl layer (#7355) [ios, macos] Source-driven attribution (#5999) [ios, macos] renamed raster-hue-rotate # Conflicts: # platform/ios/jazzy.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #7160