[core] Implement circle-stroke properties

[jfirebaugh]

Also includes stubs for fill-extrusion layer, because most of the code was auto-generated.

Submitting this ahead of the data-driven styling PR because the DDS PR also requires updating the style-spec and regenerating the style code, and these changes would otherwise come along for the ride there.

I didn't run the SDK code generation. Since this is strictly additions, I'm hopeful they'll compile nevertheless. Adding SDK bindings for circle-stroke properties can then be done in a separate step.

Fixes #7231.

[mention-bot]

@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @mollymerp, @incanus and @1ec5 to be potential reviewers.

[jfirebaugh]

I went ahead and ran the SDK code generation as well. It depends on mapbox/mapbox-gl-style-spec#617.

[1ec5]

▸ Compiling MGLMapView.mm

❌  /Users/vagrant/git/platform/darwin/src/NSValue+MGLStyleEnumAttributeAdditions.h:10:9: 'MGLFillExtrusionStyleLayer.h' file not found

#import "MGLFillExtrusionStyleLayer.h"
        ^

make darwin-style-code doesn’t automatically add MGLFillExtrusionStyleLayer.h to the project for you. Make sure to follow these steps (and the corresponding macOS steps) to make the header public.

[tobrun]

Ran the smoke tests locally, 🚢

[jfirebaugh]

@tobrun Can you see why the Android build is failing?

[Edit: never mind, I think I figured it out.]

[1ec5]

There’s a bit more accounting to do in the iOS/macOS documentation comments, but for the most part this change looks good.

These changes don’t actually add support for 3D extrusions, do they? It’s going to be weird to have an MGLFillExtrusionStyleLayer type that’s effectively a no-op.

[1ec5]

After pulling in mapbox/mapbox-gl-style-spec#619, this will say circleRadius like it’s supposed to.

[1ec5]

We override any documentation that says “sprite” to say “style image” in platform/darwin/scripts/style-spec-overrides-v8.json while we await mapbox/mapbox-gl-style-spec#220.

[1ec5]

We also use style-spec-overrides-v8.json to remove any sentence that talks about offsets or padding as arrays, because that isn’t how they’re represented in the SDK.

[1ec5]

Per #6107 (comment), we override documentation to remove the phrase “as rgba”, because this is CSS syntax, and alpha may be specified with -colorWithHue:saturation:brightness:alpha: or -colorWithWhite:alpha: instead of -colorWithRed:green:blue:alpha:.

[1ec5]

It’s kind of unfortunate that we’d be introducing references to light properties before actually adding that API to the SDK.

[1ec5]

Would be nice to say “fill extrusion” instead of “fill-extrusion” here, but that can happen in a separate PR.

[jfirebaugh]

Ok, I manually reverted all the fill-extrusion additions. It's a booby trap for whoever next runs make style-code, but I don't want to polish the docs right now. I'm just trying to ship DDS.

[1ec5]

It's a booby trap for whoever next runs make style-code

If it’s a problem, we could special-case fill-extrusion for now and delete it from the spec approximately here.