Add -fvisibility=hidden to macOS dynamic framework and export required symbols

Makefile

@@ -277,6 +277,10 @@ idocument:
 darwin-style-code:
 	node platform/darwin/scripts/generate-style-code.js
 style-code: darwin-style-code
+
+.PHONY: check-public-symbols
+check-public-symbols:
+	node platform/darwin/scripts/check-public-symbols.js macOS
 endif
 
 #### Linux targets #####################################################

platform/darwin/scripts/check-public-symbols.js

@@ -0,0 +1,83 @@
+#!/usr/bin/env node
+
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+const execFileSync = require('child_process').execFileSync;
+const _ = require('lodash');
+
+const keyword = /\bMGL_EXPORT\b/;
+
+let scanned = [];
+
+function hasMissingSymbols(os) {
+  let missing = false;
+  let sdk = os === 'iOS' ? 'iphonesimulator' : 'macosx';
+  let sysroot = execFileSync('xcrun', ['--show-sdk-path', '--sdk', sdk]).toString().trim();
+  let umbrellaPath = `platform/${os.toLowerCase()}/src/Mapbox.h`;
+  let docArgs = ['doc', '--objc', umbrellaPath, '--',
+                 '-x', 'objective-c', '-I', 'platform/darwin/src/', '-isysroot', sysroot];
+  let docStr = execFileSync('sourcekitten', docArgs).toString().trim();
+  let docJson = JSON.parse(docStr);
+  _.forEach(docJson, function (result) {
+    _.forEach(result, function (structure, path) {
+      // Prevent multiple scans of the same file.
+      if (scanned.indexOf(path) >= 0) return;
+      scanned.push(path);
+
+      const src = fs.readFileSync(path, 'utf8').split('\n');
+      _.forEach(structure['key.substructure'], function (substructure) {
+        switch (substructure['key.kind']) {
+          case 'sourcekitten.source.lang.objc.decl.class':
+            if (!(keyword.test(src[substructure['key.doc.line'] - 1]) || keyword.test(src[substructure['key.doc.line'] - 2]))) {
+              console.warn(`- missing symbol export for class ${substructure['key.name']} in ${path}:${substructure['key.doc.line']}:${substructure['key.doc.column']}`);
+              missing = true;
+            }
+            break;
+          case 'sourcekitten.source.lang.objc.decl.constant':
+            if (!keyword.test(src[substructure['key.doc.line'] - 1])) {
+              console.warn(`- missing symbol export for constant ${substructure['key.name']} in ${path}:${substructure['key.doc.line']}:${substructure['key.doc.column']}`);
+              missing = true;
+            }
+            break;
+        }
+      });
+    });
+  });
+
+  return missing;
+}
+
+function ensureSourceKittenIsInstalled() {
+  try {
+    execFileSync('which', ['sourcekitten']);
+  } catch (e) {
+    console.log(`Installing SourceKitten via Homebrew…`);
+    execFileSync('brew', ['install', 'sourcekitten']);
+  }
+}
+
+if (process.argv.length < 3) {
+  console.warn(`Usage: ${path.relative(process.cwd(), process.argv[1])} [macOS|iOS] ...`);
+  process.exit(1);
+}
+
+ensureSourceKittenIsInstalled();
+
+let missing = false;
+for (var i = 2; i < process.argv.length; i++) {
+  let os = process.argv[i];
+  if (os == 'iOS' || os == 'macOS') {
+    missing |= hasMissingSymbols(os);
+  } else {
+    console.warn(`Argument must be one of iOS or macOS`);
+    process.exit(1);
+  }
+}
+
+if (missing) {
+  process.exit(1);
+} else {
+  console.warn(`All symbols are correctly exported.`);
+}

platform/darwin/src/MGLAccountManager.h

@@ -1,11 +1,14 @@
 #import <Foundation/Foundation.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
  The MGLAccountManager object provides a global way to set a Mapbox API access
  token.
  */
+MGL_EXPORT
 @interface MGLAccountManager : NSObject
 
 #pragma mark Authorizing Access

platform/darwin/src/MGLAttributionInfo.h

@@ -2,6 +2,7 @@
 #import <CoreGraphics/CoreGraphics.h>
 #import <CoreLocation/CoreLocation.h>
 
+#import "MGLFoundation.h"
 #import "MGLTypes.h"
 
 NS_ASSUME_NONNULL_BEGIN
@@ -10,6 +11,7 @@ NS_ASSUME_NONNULL_BEGIN
  Information about an attribution statement, usually a copyright or trademark
  statement, associated with a map content source.
  */
+MGL_EXPORT
 @interface MGLAttributionInfo : NSObject
 
 /**

platform/darwin/src/MGLBackgroundStyleLayer.h

@@ -1,6 +1,7 @@
 // This file is generated. 
 // Edit platform/darwin/scripts/generate-style-code.js, then run `make style-code-darwin`.
 
+#import "MGLFoundation.h"
 #import "MGLStyleValue.h"
 #import "MGLStyleLayer.h"
 
@@ -12,6 +13,7 @@ NS_ASSUME_NONNULL_BEGIN
  `style` and obtain the background layer using the `-[MGLStyle layerWithIdentifier:]` 
  method and passing `background` for the identifier. 
  */
+MGL_EXPORT
 @interface MGLBackgroundStyleLayer : MGLStyleLayer
 
 - (instancetype)initWithIdentifier:(NSString *)identifier NS_DESIGNATED_INITIALIZER;

platform/darwin/src/MGLCircleStyleLayer.h

@@ -1,6 +1,7 @@
 // This file is generated. 
 // Edit platform/darwin/scripts/generate-style-code.js, then run `make style-code-darwin`.
 
+#import "MGLFoundation.h"
 #import "MGLStyleValue.h"
 #import "MGLVectorStyleLayer.h"
 
@@ -44,6 +45,7 @@ typedef NS_ENUM(NSUInteger, MGLCircleTranslateAnchor) {
  `MGLMapView` for its `style` and obtain existing layers using the 
  `-[MGLStyle layerWithIdentifier:]` method. 
  */
+MGL_EXPORT
 @interface MGLCircleStyleLayer : MGLVectorStyleLayer
 
 #pragma mark - Accessing the Paint Attributes

platform/darwin/src/MGLClockDirectionFormatter.h

@@ -1,6 +1,8 @@
 #import <Foundation/Foundation.h>
 #import <CoreLocation/CoreLocation.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
@@ -14,6 +16,7 @@ NS_ASSUME_NONNULL_BEGIN
  irrespective of the user’s orientation, use `MGLCompassDirectionFormatter`
  instead.
  */
+MGL_EXPORT
 @interface MGLClockDirectionFormatter : NSFormatter
 
 /**

platform/darwin/src/MGLCompassDirectionFormatter.h

@@ -1,6 +1,8 @@
 #import <Foundation/Foundation.h>
 #import <CoreLocation/CoreLocation.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
@@ -12,6 +14,7 @@ NS_ASSUME_NONNULL_BEGIN
  irrespective of the user’s current location. To format a direction relative to
  the user’s current location, use `MGLClockDirectionFormatter` instead.
  */
+MGL_EXPORT
 @interface MGLCompassDirectionFormatter : NSFormatter
 
 /**

platform/darwin/src/MGLCoordinateFormatter.h

@@ -1,13 +1,16 @@
 #import <Foundation/Foundation.h>
 #import <CoreLocation/CoreLocation.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
  The `MGLCoordinateFormatter` class provides properly formatted descriptions of
  geographic coordinate pairs. Use this class to create localized coordinate
  strings when displaying location information to users.
  */
+MGL_EXPORT
 @interface MGLCoordinateFormatter : NSFormatter
 
 /**

platform/darwin/src/MGLFeature.h

@@ -1,5 +1,6 @@
 #import <Foundation/Foundation.h>
 
+#import "MGLFoundation.h"
 #import "MGLPolyline.h"
 #import "MGLPolygon.h"
 #import "MGLPointAnnotation.h"
@@ -117,48 +118,55 @@ NS_ASSUME_NONNULL_BEGIN
  The `MGLPointFeature` class represents a point in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLPointFeature : MGLPointAnnotation <MGLFeature>
 @end
 
 /**
  The `MGLPolylineFeature` class represents a polyline in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLPolylineFeature : MGLPolyline <MGLFeature>
 @end
 
 /**
  The `MGLPolygonFeature` class represents a polygon in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLPolygonFeature : MGLPolygon <MGLFeature>
 @end
 
 /**
  The `MGLPointCollectionFeature` class represents a multipoint in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLPointCollectionFeature : MGLPointCollection <MGLFeature>
 @end
 
 /**
  The `MGLMultiPolylineFeature` class represents a multipolyline in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLMultiPolylineFeature : MGLMultiPolyline <MGLFeature>
 @end
 
 /**
  The `MGLMultiPolygonFeature` class represents a multipolygon in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLMultiPolygonFeature : MGLMultiPolygon <MGLFeature>
 @end
 
 /**
  The `MGLShapeCollectionFeature` class represents a shape collection in a
  <a href="https://www.mapbox.com/mapbox-gl-style-spec/#sources">tile source</a>.
  */
+MGL_EXPORT
 @interface MGLShapeCollectionFeature : MGLShapeCollection <MGLFeature>
 
 @property (nonatomic, copy, readonly) NS_ARRAY_OF(MGLShape<MGLFeature> *) *shapes;

platform/darwin/src/MGLFeature_Private.h

@@ -1,3 +1,4 @@
+#import "MGLFoundation.h"
 #import "MGLFeature.h"
 #import "MGLShape.h"
 
@@ -11,6 +12,7 @@ NS_ASSUME_NONNULL_BEGIN
  Returns an array of `MGLFeature` objects converted from the given vector of
  vector tile features.
  */
+MGL_EXPORT
 NS_ARRAY_OF(MGLShape <MGLFeature> *) *MGLFeaturesFromMBGLFeatures(const std::vector<mbgl::Feature> &features);
 
 /**

platform/darwin/src/MGLFillStyleLayer.h

@@ -1,6 +1,7 @@
 // This file is generated. 
 // Edit platform/darwin/scripts/generate-style-code.js, then run `make style-code-darwin`.
 
+#import "MGLFoundation.h"
 #import "MGLStyleValue.h"
 #import "MGLVectorStyleLayer.h"
 
@@ -28,6 +29,7 @@ typedef NS_ENUM(NSUInteger, MGLFillTranslateAnchor) {
  `MGLMapView` for its `style` and obtain existing layers using the 
  `-[MGLStyle layerWithIdentifier:]` method. 
  */
+MGL_EXPORT
 @interface MGLFillStyleLayer : MGLVectorStyleLayer
 
 #pragma mark - Accessing the Paint Attributes

platform/darwin/src/MGLForegroundStyleLayer.h

@@ -1,5 +1,6 @@
 #import <Foundation/Foundation.h>
 
+#import "MGLFoundation.h"
 #import "MGLStyleLayer.h"
 
 NS_ASSUME_NONNULL_BEGIN
@@ -14,6 +15,7 @@ NS_ASSUME_NONNULL_BEGIN
  subclasses of this class. Instead, create instances of `MGLRasterStyleLayer`
  and the concrete subclasses of `MGLVectorStyleLayer`.
  */
+MGL_EXPORT
 @interface MGLForegroundStyleLayer : MGLStyleLayer
 
 #pragma mark Initializing a Style Layer

platform/darwin/src/MGLFoundation.h

@@ -0,0 +1,5 @@
+#pragma once
+
+#import <Foundation/Foundation.h>
+
+#define MGL_EXPORT __attribute__((visibility ("default")))

platform/darwin/src/MGLGeometry.h

@@ -2,6 +2,8 @@
 #import <CoreLocation/CoreLocation.h>
 #import <CoreGraphics/CGBase.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /** Defines the area spanned by an `MGLCoordinateBounds`. */
@@ -33,7 +35,7 @@ NS_INLINE BOOL MGLCoordinateSpanEqualToCoordinateSpan(MGLCoordinateSpan span1, M
 }
 
 /** An area of zero width and zero height. */
-extern const MGLCoordinateSpan MGLCoordinateSpanZero;
+extern MGL_EXPORT const MGLCoordinateSpan MGLCoordinateSpanZero;
 
 /** A rectangular area as measured on a two-dimensional map projection. */
 typedef struct MGLCoordinateBounds {

platform/darwin/src/MGLGeometry.mm

@@ -1,5 +1,7 @@
 #import "MGLGeometry_Private.h"
 
+#import "MGLFoundation.h"
+
 #import <mbgl/util/projection.hpp>
 
 /** Vertical field of view, measured in degrees, for determining the altitude
@@ -30,13 +32,15 @@ CGRect MGLExtendRect(CGRect rect, CGPoint point) {
     return rect;
 }
 
+MGL_EXPORT
 CLLocationDistance MGLAltitudeForZoomLevel(double zoomLevel, CGFloat pitch, CLLocationDegrees latitude, CGSize size) {
     CLLocationDistance metersPerPixel = mbgl::Projection::getMetersPerPixelAtLatitude(latitude, zoomLevel);
     CLLocationDistance metersTall = metersPerPixel * size.height;
     CLLocationDistance altitude = metersTall / 2 / std::tan(MGLRadiansFromDegrees(MGLAngularFieldOfView) / 2.);
     return altitude * std::sin(M_PI_2 - MGLRadiansFromDegrees(pitch)) / std::sin(M_PI_2);
 }
 
+MGL_EXPORT
 double MGLZoomLevelForAltitude(CLLocationDistance altitude, CGFloat pitch, CLLocationDegrees latitude, CGSize size) {
     CLLocationDistance eyeAltitude = altitude / std::sin(M_PI_2 - MGLRadiansFromDegrees(pitch)) * std::sin(M_PI_2);
     CLLocationDistance metersTall = eyeAltitude * 2 * std::tan(MGLRadiansFromDegrees(MGLAngularFieldOfView) / 2.);

platform/darwin/src/MGLLineStyleLayer.h

@@ -1,6 +1,7 @@
 // This file is generated. 
 // Edit platform/darwin/scripts/generate-style-code.js, then run `make style-code-darwin`.
 
+#import "MGLFoundation.h"
 #import "MGLStyleValue.h"
 #import "MGLVectorStyleLayer.h"
 
@@ -68,6 +69,7 @@ typedef NS_ENUM(NSUInteger, MGLLineTranslateAnchor) {
  `MGLMapView` for its `style` and obtain existing layers using the 
  `-[MGLStyle layerWithIdentifier:]` method. 
  */
+MGL_EXPORT
 @interface MGLLineStyleLayer : MGLVectorStyleLayer
 
 #pragma mark - Accessing the Layout Attributes

platform/darwin/src/MGLMapCamera.h

@@ -2,12 +2,15 @@
 #import <CoreGraphics/CoreGraphics.h>
 #import <CoreLocation/CoreLocation.h>
 
+#import "MGLFoundation.h"
+
 NS_ASSUME_NONNULL_BEGIN
 
 /**
  An `MGLMapCamera` object represents a viewpoint from which the user observes
  some point on an `MGLMapView`.
  */
+MGL_EXPORT
 @interface MGLMapCamera : NSObject <NSSecureCoding, NSCopying>
 
 /** Coordinate at the center of the map view. */