Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[ios] read only annotation#8265

Closed
fabian-guerra wants to merge 1 commit into
release-ios-v3.5.0-android-v5.0.0from
fabian-read-only-annotation-release
Closed

[ios] read only annotation#8265
fabian-guerra wants to merge 1 commit into
release-ios-v3.5.0-android-v5.0.0from
fabian-read-only-annotation-release

Conversation

@fabian-guerra
Copy link
Copy Markdown
Contributor

This fix was merged into master but should be merged into release branch.
\cc @boundsj

@fabian-guerra fabian-guerra added annotations Annotations on iOS and macOS or markers on Android iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS labels Mar 3, 2017
@fabian-guerra fabian-guerra added this to the ios-v3.5.0 milestone Mar 3, 2017
@fabian-guerra fabian-guerra self-assigned this Mar 3, 2017
@fabian-guerra fabian-guerra requested a review from boundsj March 3, 2017 01:07
@mention-bot
Copy link
Copy Markdown

@fabian-guerra, thanks for your PR! By analyzing this pull request, we identified @boundsj, @1ec5 and @incanus to be potential reviewers.

@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Mar 3, 2017

/ref #8139

@fabian-guerra fabian-guerra force-pushed the fabian-read-only-annotation-release branch from 3a1e1d7 to e63444d Compare March 3, 2017 16:11
@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Mar 9, 2017

This went into the release branch as part of #8324. Nothing left to do here.

@1ec5 1ec5 closed this Mar 9, 2017
@1ec5 1ec5 deleted the fabian-read-only-annotation-release branch March 9, 2017 23:17
@fabian-guerra
Copy link
Copy Markdown
Contributor Author

@1ec5 this branch raises an NSException instead of using an NSAssert

@1ec5
Copy link
Copy Markdown
Contributor

1ec5 commented Mar 10, 2017

Ah, I missed that. Can you open a new PR that does just that, now that all the other changes are already included in the release branch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

annotations Annotations on iOS and macOS or markers on Android iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants