This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Add Glyph Atlas debug window back#8266
Closed
kkaefer wants to merge 1 commit into
Closed
Conversation
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @artemp and @tmpsantos to be potential reviewers. |
Member
Author
|
/cc @ChrisLoer |
Contributor
|
Pretty sure this code is going to continue to be a tempting target for removal if it's commented and ifdeffed out -- not to mention getting broken by changes since it's not compiled by default. Can we figure out a more durable solution? |
Member
Author
|
This needs significant refactoring once #9213 lands. |
Contributor
|
Stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point we lost the commented out code that shows the glyph window in GLFW.