This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[android] - Style wide transition options in milliseconds#8576
Merged
Conversation
tobrun
force-pushed
the
8575-style-transitionoptions-in-ms
branch
2 times, most recently
from
6e5fc20 to
74be2bd
Compare
…up test activity code
tobrun
force-pushed
the
8575-style-transitionoptions-in-ms
branch
from
74be2bd to
3238dc4
Compare
ivovandongen
approved these changes
Mar 30, 2017
Contributor
ivovandongen
left a comment
ivovandongen
left a comment
There was a problem hiding this comment.
Looks good! Wonder if this requires a major version increase though..
| * @param durationMs Duration in milliseconds | ||
| */ | ||
| @UiThread | ||
| public void setTransitionDuration(long duration) { |
Contributor
There was a problem hiding this comment.
Do we consider this a breaking change?
Contributor
There was a problem hiding this comment.
Why not use java.time.Duration for durations and avoid unit bugs through type safety?
Member
Author
There was a problem hiding this comment.
Ivo mentioned the same on chat regards using Duration from joda.time, will ticket it out.
This was referenced May 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8575
cc @incanus