This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Limit Viewport#8622
Merged
Merged
Conversation
tobrun
force-pushed
the
android-map-latlngbounds
branch
from
37344dc to
82ce572
Compare
ivovandongen
suggested changes
Apr 4, 2017
Contributor
ivovandongen
left a comment
ivovandongen
left a comment
There was a problem hiding this comment.
Some small changes, looks good otherwise!
| } | ||
|
|
||
| void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) { | ||
| if(jBounds==NULL){ |
| void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) { | ||
| if(jBounds==NULL){ | ||
| map->setLatLngBounds(mbgl::LatLngBounds::world()); | ||
| }else{ |
|
|
||
| void setStyleJson(jni::JNIEnv&, jni::String); | ||
|
|
||
| void setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds>); |
tobrun
force-pushed
the
android-map-latlngbounds
branch
3 times, most recently
from
e0442f9 to
8061a59
Compare
Member
Author
|
#8583 landed, ready for final review @ivovandongen? |
tobrun
force-pushed
the
android-map-latlngbounds
branch
from
8061a59 to
4941aa9
Compare
This was referenced May 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android binding integration of #8583.
closes #3602