Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Set firsRender flag to false when destroying the surface#8739

Merged
tobrun merged 1 commit into
masterfrom
8725-first-render-true-on-destroy
Apr 19, 2017
Merged

Set firsRender flag to false when destroying the surface#8739
tobrun merged 1 commit into
masterfrom
8725-first-render-true-on-destroy

Conversation

@tobrun
Copy link
Copy Markdown
Member

@tobrun tobrun commented Apr 13, 2017

Closes #8725
Closes #6647

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Apr 13, 2017
@tobrun tobrun added this to the android-v5.1.0 milestone Apr 13, 2017
@tobrun tobrun self-assigned this Apr 13, 2017
@tobrun tobrun requested a review from ivovandongen April 13, 2017 10:36
Copy link
Copy Markdown
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to have a way to reproduce this? Otherwise fine.

@tobrun
Copy link
Copy Markdown
Member Author

tobrun commented Apr 19, 2017

@ivovandongen tried reproducing but couldn't trigger it, though the change makes sense imo.
Do you want to take a stab at reproducing before merging?

@tobrun tobrun merged commit 090677a into master Apr 19, 2017
@tobrun tobrun deleted the 8725-first-render-true-on-destroy branch April 21, 2017 09:08
@tobrun tobrun mentioned this pull request May 2, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 9, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Android Mapbox Maps SDK for Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants