This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Don't crash on tap when an AnnotationVIew doesn’t have an annotation#8755
Closed
JesseCrocker wants to merge 1 commit into
Closed
[ios] Don't crash on tap when an AnnotationVIew doesn’t have an annotation#8755JesseCrocker wants to merge 1 commit into
JesseCrocker wants to merge 1 commit into
Conversation
Contributor
|
Thanks so much! I'm closing for the reasons stated in #8754 (comment)
Let's continue to track this in #8754 and the PRs listed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8754
MGLAnnotationView.annotation is marked as nullable, and i think there is a good case to be made that custom annotations views should be able to set their annotation to nil when removed from the map, so enforcing non-null here seems like a bug, and one that there is no easy way to workaround because it is throwing an exception in a call to UIGestureRecognizerDelegate.