This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Harden telemetry event dispatch#8767
Merged
Merged
Conversation
8795f95 to
1d41a0f
Compare
zugaldia
approved these changes
Apr 20, 2017
This was referenced May 18, 2017
Larnoo
reviewed
Jul 20, 2017
There was a problem hiding this comment.
+ try {
+ return MapboxEvent.buildMapClickEvent(location, gestureId, transform.getZoom());
+ } catch (NullPointerException exception) {
+ // Map/Transform is not ready yet #8650
+ // returning null is valid, event is ignored.
+ return null;
+ }
why catch NPE? If catch NPE, other object is null will hidden the problem.
catching Exception is costly.
I think should do as follow.
if(transform==null){
//the transform is null; can't do anything. or print log.
return null;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8650, this PR introduces a wrapper implementation of MapboxEvent. This is needed to ignore events when the Map isn't ready to handle them (when we don't have a camera position to get the zoom level from). A use-case where this can occur is running monkeyrunner, note that I haven't been able to reproduce with normal behavior.