This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Store vertex attribute binding to prevent duplicate binds#9181
Merged
Conversation
kkaefer
added
Core
kkaefer
commented
Jun 4, 2017
| if (oldBinding) { | ||
| MBGL_CHECK_ERROR(glDisableVertexAttribArray(location)); | ||
| oldBinding = {}; | ||
| } |
Member
Author
There was a problem hiding this comment.
This fails when we're not using VAOs. In that case, we're resetting the binding for every segment we're drawing to force a rebind, so oldBinding will always be empty and we may fail to disable the vertex attribute array for a certain location.
Contributor
There was a problem hiding this comment.
Right, so revert all of these changes, leaving only the oldBinding = *this; change?
We have an "oldBinding" value that we use for checking whether the vertex attribute was already bound to the current VAO, but we never set the state. Additionally, we're also checking whether the previous state was already any binding (optional is set), and don't re-enable the vertex attribute array. Additionally, we now only disable the vertex attribute array when the previous state was in fact an array attribute. We still don't deduplicate constant glVertexAttrib* calls, but that's a little trickier.
kkaefer
force-pushed
the
dont-rebind-vertex-arrays
branch
from
96b30a0 to
2a5879e
Compare
Member
Author
|
Ready for review |
jfirebaugh
approved these changes
Jun 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an
oldBindingvalue that we use for checking whether the vertex attribute was alreadybound to the current VAO, but we never set the state. Additionally, we're also checking whether
the previous state was already any binding (
optionalis set), and don't re-enable the vertexattribute array. Additionally, we now only disable the vertex attribute array when the previous
state was in fact an array attribute. We still don't deduplicate constant
glVertexAttrib*calls,but that's a little trickier.