This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[core] Don't upload the FrameHistory texture in frames where it's not changing#9257
Merged
Conversation
4 tasks
jfirebaugh
changed the title
jfirebaugh
changed the title
jfirebaugh
force-pushed
the
frame-history-perf
branch
from
862b39e to
d3b539e
Compare
ansis
approved these changes
Jun 13, 2017
Contributor
ansis
left a comment
ansis
left a comment
There was a problem hiding this comment.
This looks good
brings FPS on the bench app to 60 on my iPhone 6 across all locations.
It seems like having a benchmark that includes this significant cost would be good. Should the benchmark be changed to include zooming?
kkaefer
approved these changes
Jun 13, 2017
| opacities.data[z] = util::min(255, changeOpacities[z] + opacityChange); | ||
| } else { | ||
| opacities.data[z] = util::max(0, changeOpacities[z] - opacityChange); | ||
| uint8_t opacity = z <= zoomIndex |
Contributor
Author
|
For some reason this seems to be triggering timeouts on the Android Firebase tests. Can someone @mapbox/android take a look? |
Member
|
@jfirebaugh looks like Firebase was in a bad state, canceling the jobs and restarting them did the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When combined with #9185, brings FPS on the bench app to 60 on my iPhone 6 across all locations.