Rename references of mapIds to tileSetIds#1022
Merged
Merged
Conversation
osana
reviewed
May 2, 2019
Contributor
osana
left a comment
osana
left a comment
There was a problem hiding this comment.
Could we use this opportunity to actually test that it is working?
I do not think we have any tests for it.
Author
|
These also need to be changed, correct @osana ? Or would that somehow break semver major? |
Contributor
|
@langsmith Yes. you are right! This becomes a semver major change => Added to 5.5.0 milestone |
langsmith
force-pushed
the
ls-updating-mapID-references-to-tile-ID
branch
from
21a7905 to
feeb5b8
Compare
Contributor
|
@langsmith I take it back about the tests. I see that both the request and the response are tested |
Author
|
Any other changes desired, @osana ? |
langsmith
force-pushed
the
ls-updating-mapID-references-to-tile-ID
branch
from
741111e to
4a63df2
Compare
tobrun
approved these changes
Jun 11, 2019
langsmith
pushed a commit
that referenced
this pull request
Jun 11, 2019
This reverts commit 072b984.
langsmith
pushed a commit
that referenced
this pull request
Jun 11, 2019
This was referenced Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1021 by refactoring references of
mapIdstotileSetIdscc @1ec5