Conveniences to Position model#309
Merged
Merged
Conversation
|
@zugaldia, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cammace and @ivovandongen to be potential reviewers. |
Contributor
|
Position is still used with the Android SDK's runtime styling API, right? Note that out-of-range longitudes are expected for features that straddle the antimeridian. |
Member
Author
|
@1ec5 Right, we're tracking a couple of antimeridian-related issues here. |
Contributor
|
Yes, but doesn’t antimeridian straddling already work in the Android SDK? mapbox/mapbox-gl-native#6088 Or does that affect only annotations, which would use the SDK-specific model objects? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Position.fromLngLat(double longitude, double latitude)method the be more explicit about the lat/lon order. It does not deprecate thePosition.fromCoordinates()method as this is used for other cases too (e.g. set an altitude or a double array). Fixes Rename Position.fromCoordinate() to fromLngLat() #283.Positionconstructor if the lat/lon values seem out of range. Fixes Add Position check for correct order #266.This last item is tested via the Test App. In
MainActivitywe create an object with values out of range and the warning can be seen as usual in the Android log window:@cammace Please review.