onArrival doesn't get called if navigation is started with multiple stops

[hussi1]

If i start Navigation with multiple waypoints then onarrival does not get called when a waypoint is reached.
Heres how i am getting route with multiple waypoints :

NavigationRoute.Builder builder = NavigationRoute.builder(HomeActivity.this)
.accessToken(Mapbox.getAccessToken())
.origin(originPoint)
.destination(destinationPoint);
if (address_list.size()>2) {
for (int i=1;i<address_list.size()-1;i++) {
builder.addWaypoint(Point.fromLngLat(address_list.get(i).getLongitude(),address_list.get(i).getLatitude()));
}
}
builder.profile(DirectionsCriteria.PROFILE_DRIVING)
.annotations(DirectionsCriteria.ANNOTATION_CONGESTION)
.alternatives(true);
builder.build()
.getRoute(this);

Android API: 28
Mapbox Navigation SDK version: com.mapbox.mapboxsdk:mapbox-android-navigation-ui:0.34.0

Steps to trigger behavior

1.Start a Navigation with waypoints

Expected behavior

onArrival should be called at every waypoint

Actual behavior

onArrival is only called on destination

[danesfeder]

Hey @hussi1 thanks for the report here. We will look into this!

@kevinkreiser from a Navigator route status standpoint this is unexpected behavior right?

[asegestam]

I'm having the same issue, I've also tried routeUtils.isArrivalEvent(routeProgress) in my onProgressChanged but when I reach my destination the route progress state is LOCATION_STALE and never becomes ROUTE_ARRIVED,.

[hussi1]

routeUtils.isArrivalEvent(routeProgress) not working for me either.

[danesfeder]

@hussi1 @asegestam this looks like a possible bug on our side that we are looking into.

In the meantime, can you disable MapboxNavigationOptions#enableAutoIncrementLegIndex(false). With that option set to false, you will need to increment the leg index manually when you're ready to do so with MapboxNavigation#updateRouteLegIndex(int legIndex). With this setup, you will be able to receive the complete status and arrival listener callback.

We will continue to look into the issue with auto-incrementing. Thanks for your patience!

[hussi1]

At what point will i increment legIndex ?

[danesfeder]

Hey @hussi1, we just merged a fix for this.

But you would increment in the ProgressChangeListener looking at RouteProgress#currentState() and then increment when it is ROUTE_ARRIVED

[hussi1]

Will i have to update version for this ? or its in same version, I checked on both 0.34.0 and 0.36.0
@asegestam did it solved for you ?

[asegestam]

@hussi1 No, I've tested with the same versions as you. I think this will be released in a future update.

[Guardiola31337]

@hussi1 @asegestam that's correct, it'll be included in the upcoming release v0.37.0.

In the meantime, as my colleague @danesfeder explained above you could do #1904 (comment) and #1904 (comment) should workaround it. Thanks both for checking out the SDK and helping out troubleshooting the issue.

[hussi1]

@danesfeder Thats how i am updating leg manually
if (routeProgress.currentState() == RouteProgressState.ROUTE_ARRIVED){
MapboxNavigation mapboxNavigation = new MapboxNavigation(getActivity(),Mapbox.getAccessToken());
mapboxNavigation.updateRouteLegIndex(routeProgress.legIndex()+1);
}
but getting crashed on update

java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.List com.mapbox.api.directions.v5.models.DirectionsRoute.legs()' on a null object reference
at com.mapbox.services.android.navigation.v5.navigation.MapboxNavigation.checkInvalidLegIndex(MapboxNavigation.java:970)
at com.mapbox.services.android.navigation.v5.navigation.MapboxNavigation.updateRouteLegIndex(MapboxNavigation.java:782)