Telemetry distancecompleted can be -2147483648

[kmadsen]

Mapbox Navigation SDK version: 1.0.0

Steps to trigger behavior

https://app.mode.com/editor/mapbox/reports/36579db91d6d

distancecompleted is incorrect in telemetry.

Expected behavior

distancecompleted = 0 to estimateddistance

Actual behavior

distancecompleted can be -2147483648 (aka MIN_INTEGER)

[kmadsen]

Have verified that this is not 100% reproducible. Through testing have seen that distancecompleted is calculated accurately

[kmadsen]

Added a query to see how often this happens per session. Technically, it can only be reproduced 20% of the time 😢 😆

error sessions	total sessions	success_rate
34	177	80.8%

[kmadsen]

Found a likely cause for this issue. It's when you arrive at your destination and continue moving

D/MAPBOX_TELEMETRY: ARRIVAL event sent true
arrival_debug distanceRemaining 5.92887
arrival_debug distanceRemaining -9.536743E-7
arrival_debug distanceRemaining -9.536743E-7
arrival_debug distanceRemaining -9.536743E-7
arrival_debug distanceRemaining -9.536743E-7
arrival_debug distanceRemaining -9.536743E-7
arrival_debug distanceRemaining -9.536743E-7

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Guardiola31337]

Commenting here so this ticket is not automatically closed by stale bot as it's still relevant.

[Guardiola31337]

Where are we here @kmadsen? Is this still an issue?

Refs. #3164

[kmadsen]

re-ran the query and the issue is still happening on 1tap. fair to say it's still an issue
https://app.mode.com/editor/mapbox/reports/36579db91d6d

useragent	created	event	session	distanceremaining	originalestimateddistance	estimateddistance	distancecompleted
com.mapbox.onetap.app/v0.17.0/998351 mapbox-navigation-android/1.0.0-rc.7	2020-09-09 7:53:52	navigation.cancel	aace88fe-47fb-4aa2-8d6c-f883b746addf	56	6152	484	-2147483648
com.mapbox.onetap.app/v0.17.0/998351 mapbox-navigation-android/1.0.0-rc.7	2020-09-09 7:53:51	navigation.reroute	aace88fe-47fb-4aa2-8d6c-f883b746addf	56	6152	484	-2147483648
com.mapbox.onetap.app/v0.17.0/998351 mapbox-navigation-android/1.0.0-rc.7	2020-09-09 7:53:49	navigation.reroute	aace88fe-47fb-4aa2-8d6c-f883b746addf	56	6152	484	-2147483648
com.mapbox.onetap.app/v0.17.0/998351 mapbox-navigation-android/1.0.0-rc.7	2020-09-09 7:53:38	navigation.feedback	aace88fe-47fb-4aa2-8d6c-f883b746addf	484	6152	484	-2147483648

[korshaknn]

@kmadsen @Guardiola31337
hey! going to fix it during telemetry refactoring. how do we calculate distanceCompleted?
I just use
distanceCompleted = routeProgress.distanceTraveled.toInt()
is it valid ^^ ?
should we have any additional calculations for offRoute event?

[Guardiola31337]

@korshaknn

how do we calculate distanceCompleted?
I just use
distanceCompleted = routeProgress.distanceTraveled.toInt()
is it valid ^^ ?
should we have any additional calculations for offRoute event?

That should be handled by NN. We recently started relying on whatever is sent from NN

mapbox-navigation-android/libnavigator/src/main/java/com/mapbox/navigation/navigator/internal/NavigatorMapper.kt

Lines 122 to 123 in c2e0546

	val routeDistanceTraveled = activeGuidanceInfo.routeProgress.distanceTraveled
	routeProgressBuilder.distanceTraveled(routeDistanceTraveled.toFloat())

#3604 (previously we some of the computations were done inside the SDK code). Can we retest and see if this still an issue? This landed in v1.2.0-alpha.1.

cc @kmadsen

[kmadsen]

how do we calculate distanceCompleted?

mapbox-navigation-android/libnavigation-core/src/main/java/com/mapbox/navigation/core/telemetry/MapboxNavigationTelemetry.kt

Lines 632 to 635 in c5b8f61

	dynamicValues.distanceCompleted.set(
	dynamicValues.distanceCompleted.get() +
	routeData.routeProgress.distanceTraveled
	)

Adding to pablo's comment cause here is where distanceCompleted is literally set

Rerunning the query that's in the description: https://app.mode.com/editor/mapbox/reports/36579db91d6d

SELECT 
  event,
  count(distinct CASE WHEN (distancecompleted = -2147483648) THEN sessionidentifier ELSE NULL END) as error_sessions,
  count(distinct sessionidentifier) as total_sessions
FROM sdk_events.combined_events 
WHERE  cast(dt AS timestamp) > NOW() - INTERVAL '5' DAY
  and sdkversion like '1.%'
  and useragent like '{enter-test-app}'
GROUP BY event

This appears fixed! 🥳 . We also would like to verify with thousands of sessions, where we are still in the hundreds. We can re-open this when/if we see it again.