Remove attempt to place route source when style layers are null#1006
Merged
Conversation
Guardiola31337
approved these changes
Jun 11, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
We’re adding a bunch of null checks all over the code. Eventually, we should revisit this strategy of "solving" these kind of bugs (NPEs).
In any case, we all know NavigationMapRoute needs a major overhaul so 
for now.
danesfeder
force-pushed
the
dan-fix-null-stylelayers
branch
from
c2794c2 to
e73a730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI video below - maybe this was an issue with the map loading?
Closes #1005