Remove metric arrival event reset for multiple waypoints#1022
Merged
Conversation
9c02f3c to
55478a4
Compare
Contributor
But Firebase doesn't think so 😂 |
55478a4 to
e02ecb4
Compare
e02ecb4 to
1ff67f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1012
The off route listener was not being removed upon arrival because the
metricArrivalListenerwasnull. This was a regression from #943. Now that we use milestones, the milestone listener will only fire once and we don't need to worry about resetting a listener / duplicate events as a result.Using the three waypoints from the ticket:
