Check for valid name property value in MapWayname#1031
Merged
Conversation
danesfeder
force-pushed
the
dan-wayname-npe
branch
from
e17e993 to
b14a7b4
Compare
Guardiola31337
approved these changes
Jun 15, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Minor thing not blocking the PR but definitely worth 👀
| } | ||
|
|
||
| @Test | ||
| public void onFeatureWithoutNamePropertyReturned_updateIsIgnored() { |
| @@ -71,12 +71,15 @@ private List<Feature> findRoadLabelFeatures(PointF point) { | |||
|
|
|||
| private void updateLayerWithRoadLabelFeatures(List<Feature> roads, SymbolLayer waynameLayer) { | |||
| if (!roads.isEmpty()) { | |||
Contributor
There was a problem hiding this comment.
IMO updateLayerWithRoadLabelFeatures is getting too long.
What about extracting blocks of code into well-named private methods and simplifying conditional expressions somehow?
danesfeder
force-pushed
the
dan-wayname-npe
branch
from
b14a7b4 to
50a3985
Compare
danesfeder
force-pushed
the
dan-wayname-npe
branch
from
50a3985 to
33b4ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1029