Remove setting voiceLanguage / voice unitType in RouteFetcher#1046
Merged
Conversation
Guardiola31337
approved these changes
Jun 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #991
In the
RouteFetcherwe are currently setting the route request language and voice unit from the cached route progress object.This is actually redundant, done here https://github.com/mapbox/mapbox-navigation-android/compare/dan-null-voice-fix?expand=1#diff-0d0ceee348988e299f61b3730574d4a8R102
For the re-route request we should be using the
RouteOptions#languageas the the directions routevoiceLanguagecan be null, causing the issue seen in the ticket.https://github.com/mapbox/mapbox-navigation-android/compare/dan-null-voice-fix?expand=1#diff-0d0ceee348988e299f61b3730574d4a8L105