Skip to content

Update Maps v6.6.0 release#1310

Merged
Guardiola31337 merged 2 commits into
masterfrom
maps-qa-6.6.0
Oct 12, 2018
Merged

Update Maps v6.6.0 release#1310
Guardiola31337 merged 2 commits into
masterfrom
maps-qa-6.6.0

Conversation

@Guardiola31337
Copy link
Copy Markdown
Contributor

Part of Testing Maps SDK pre-releases downstream

  • Tests Maps v6.6.0-alpha.1 release

cc @danesfeder

@danesfeder danesfeder changed the title Test Maps v6.6.0 release Update Maps v6.6.0 release Oct 11, 2018
@danesfeder danesfeder self-requested a review October 11, 2018 14:57
@danesfeder danesfeder added this to the 0.21.0 milestone Oct 11, 2018
Copy link
Copy Markdown
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the testing here @Guardiola31337 🚢

@Guardiola31337
Copy link
Copy Markdown
Contributor Author

CI is ❌ because mapbox-android-telemetry:3.2.1 brought breaking changes 👀 mapbox/mapbox-events-android#160 (review)

Guardiola31337 added 2 commits October 12, 2018 19:41
…by bumping mapbox-android-sdk to 6.6.0 version and bump mapbox-android-telemetry version to 3.3.0
@Guardiola31337
Copy link
Copy Markdown
Contributor Author

CI is ❌ because mapbox-android-telemetry:3.2.1 brought breaking changes 👀 mapbox/mapbox-events-android#160 (review)

This should be fixed now. Do you mind @danesfeder giving a round 👀 to the changes introduced in fb37bc3? The new fields added in NavigationMetadata are String tripIdentifier, int legIndex, int legCount, int stepIndex, int stepCount and int totalStepCount. Let me know if you spot something weird in the calculation of those.

Copy link
Copy Markdown
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for telem look good, thanks for taking care of that 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants