Consume Sub BannerText in InstructionView#1408
Merged
Merged
Conversation
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Nothing here that large portions of the
InstructionModelandInstructionStepResourcesare being created / calculated for the deprecatedInstructionView#updatemethod. Does it make sense to remove the method, break the API and remove the unnecessary model work?
Yes please 🙏 Let's remove the unnecessary code!
I think it's fine as soon as we ensure that the release notes and the android docs site are updated with these breaking changes 🚀
Other than that ☝️ this looks good to me.
Thanks @danesfeder
danesfeder
added
the
backwards incompatible
Contributor
Author
|
@Guardiola31337 this is updated and ready for another round 👀 |
Guardiola31337
approved these changes
Oct 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1228
Nothing here that large portions of the
InstructionModelandInstructionStepResourcesare being created / calculated for the deprecatedInstructionView#updatemethod. Does it make sense to remove the method, break the API and remove the unnecessary model work?