Fix shields not showing up for some display densities#1414
Merged
Conversation
Guardiola31337
force-pushed
the
pg-shields-display-density-issue
branch
from
73009a5 to
996dd53
Compare
danesfeder
approved these changes
Oct 15, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
@Guardiola31337 great catch on this 🚢
Noting that this can be revisited / refactored with less if (Build.VERSION.SDK_INT, maybe something like a provider + Build specific maps like you have suggested in previous reviews.
Contributor
Author
Yeah, I completely agree. In any case, it’s well contained under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #992 - noting that this PR doesn't fix #992 (comment)