Add no value checks for FixLocation in MapboxNavigator#1426
Merged
Conversation
Guardiola31337
force-pushed
the
pg-fix-location-fields
branch
from
1ddf4f8 to
a4ea0e7
Compare
kevinkreiser
approved these changes
Oct 16, 2018
danesfeder
approved these changes
Oct 16, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
One minor naming comment 🚢 not blocking
| ); | ||
| } | ||
|
|
||
| private Float checkNo(Float value) { |
Contributor
There was a problem hiding this comment.
What about this updated naming?
Suggested change
| private Float checkNo(Float value) { | |
| private Float checkFor(Float value) { |
or
Suggested change
| private Float checkNo(Float value) { | |
| private Float checkNoValueFor(Float value) { |
Guardiola31337
force-pushed
the
pg-fix-location-fields
branch
from
a4ea0e7 to
b0cebeb
Compare
Guardiola31337
force-pushed
the
pg-fix-location-fields
branch
from
b0cebeb to
574f65f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixLocationinMapboxNavigator