Skip to content

Check for null maneuver type in ManeuverView#1429

Merged
danesfeder merged 1 commit into
masterfrom
dan-null-sub-type
Oct 16, 2018
Merged

Check for null maneuver type in ManeuverView#1429
danesfeder merged 1 commit into
masterfrom
dan-null-sub-type

Conversation

@danesfeder
Copy link
Copy Markdown
Contributor

@danesfeder danesfeder commented Oct 16, 2018 

Fatal Exception: java.lang.NullPointerException
Attempt to invoke virtual method 'boolean java.lang.String.contentEquals(java.lang.CharSequence)' on a null object reference
com.mapbox.services.android.navigation.ui.v5.instruction.maneuver.ManeuverView.checkManeuverModifier (ManeuverView.java:176)
com.mapbox.services.android.navigation.ui.v5.instruction.maneuver.ManeuverView.setManeuverTypeAndModifier (ManeuverView.java:110)
com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView.updateSubStep (InstructionView.java:682)
com.mapbox.services.android.navigation.ui.v5.instruction.InstructionView.updateBannerInstructionsWith (InstructionView.java:253)

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Oct 16, 2018
@danesfeder danesfeder added this to the 0.22.0 milestone Oct 16, 2018
@danesfeder danesfeder self-assigned this Oct 16, 2018
@danesfeder danesfeder requested review from Guardiola31337, devotaaabel, kevinkreiser and nitaliano and removed request for devotaaabel October 16, 2018 20:13
@danesfeder danesfeder merged commit 33f54f5 into master Oct 16, 2018
@danesfeder danesfeder deleted the dan-null-sub-type branch October 16, 2018 20:28
@danesfeder danesfeder mentioned this pull request Oct 24, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitaliano nitaliano Awaiting requested review from nitaliano

2 more reviewers

@kevinkreiser kevinkreiser kevinkreiser approved these changes

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danesfeder danesfeder

Labels

bug Defect to be fixed.

Projects

None yet

Milestone

0.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danesfeder @kevinkreiser @Guardiola31337