Fix sub BannerText loading shields for first time#1446
Merged
Conversation
Guardiola31337
approved these changes
Oct 23, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Good catch @danesfeder 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time we are showing the
sub_instruction_layout.xml,TextView#getWidth()is returning0, because it hasn't been drawn on the screen yet. OurtruncateImageSpanmethod was seeing this and returning""because it thinks there isn't any room to show anything. We should check the available space before we run that truncation code. FWIW, this truncation code should be less necessary with the abbreviation work.We were seeing:
This PR: