Adjust InstructionView primary and secondary loading logic#1451
Merged
Conversation
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Other than this minor comment, this looks good to me 🚀
Thanks @danesfeder 🙇
| upcomingSecondaryText.setVisibility(GONE); | ||
| adjustBannerTextVerticalBias(0.5f); | ||
|
|
||
| InstructionLoader instructionLoader = createInstructionLoader(upcomingPrimaryText, primaryBannerText); |
Contributor
There was a problem hiding this comment.
What about extracting this block of code into a new method and reuse it here and also in loadPrimaryAndSecondary method below?
danesfeder
force-pushed
the
dan-primary-cutoff
branch
2 times, most recently
from
914afdf to
d0eae54
Compare
Contributor
Author
|
@Guardiola31337 sure thing - updated. This is ready for another round 👀 |
danesfeder
force-pushed
the
dan-primary-cutoff
branch
from
d0eae54 to
3fdfacc
Compare
Guardiola31337
approved these changes
Oct 23, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @danesfeder 🚢
danesfeder
force-pushed
the
dan-primary-cutoff
branch
from
3fdfacc to
623bf5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing behavior where we are receiving a primary
BannerTextand setting it, but then showing the secondaryTextViewas well (without any text). This PR aims to improve the logic for hiding / showing these views making it more straightforward.