Rebuild MapboxNavigationNotification for each update#1455
Conversation
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks @danesfeder for implementing the suggestions from #1441 (comment)
Let's give this a try and see if we don't see that TransactionTooLargeException 🐛 anymore!
🚢 🚢
| private int currentManeuverId; | ||
| private boolean isTwentyFourHourFormat; | ||
| private String etaFormat; | ||
| private final Context context; |
There was a problem hiding this comment.
Minor comment - to note that should be an application context, what about calling it applicationContext instead? As in
danesfeder
force-pushed
the
dan-rebuild-notification
branch
from
97040c9 to
df218e9
Compare
|
@danesfeder The data in the Notification is still not matching the And is their also a way to prevent the Notification from showing at all?
|
|
@Danny-James you can create your own notification with https://www.mapbox.com/android-docs/navigation/overview/navigation-options/#creating-a-custom-notification |
|
@danesfeder Instead of creating my own, is their a documented way of stopping the default notification, as i don't think we need it to be honest? But if we do in the future at least i'm aware on disabling the default and/or creating my own. |
|
@Danny-James we had to remove the option to disable because on Oreo+ a |
|
@danesfeder does the default notification have a layout file I could replicate? |
3 participants
Fixes #1188 and Closes #1441
See #1441 for further explanation / discussion.