Skip to content

Allow default notification color setting via MapboxNavigationOptions#1899

Merged
danesfeder merged 1 commit into
masterfrom
dan-default-color
Apr 18, 2019
Merged

Allow default notification color setting via MapboxNavigationOptions#1899
danesfeder merged 1 commit into
masterfrom
dan-default-color

Conversation

@danesfeder
Copy link
Copy Markdown
Contributor

Description

Closes #1527

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Allow developers to still utilize our default MapboxNavigationNotification, but adjust the color to the theme of their application.

Implementation

A @ColorRes int added to the MapboxNavigationOptions that is then consumed by the notification.

Screenshots or Gifs

ezgif com-video-to-gif

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1899 into master will decrease coverage by 0.02%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##             master    #1899      +/-   ##
============================================
- Coverage     35.07%   35.04%   -0.03%     
  Complexity     1060     1060              
============================================
  Files           261      261              
  Lines          8839     8848       +9     
  Branches        667      667              
============================================
+ Hits           3100     3101       +1     
- Misses         5467     5475       +8     
  Partials        272      272

@danesfeder danesfeder merged commit b45a820 into master Apr 18, 2019
@danesfeder danesfeder deleted the dan-default-color branch April 18, 2019 17:50
@danesfeder danesfeder mentioned this pull request May 1, 2019
11 tasks
@bonnyfone
Copy link
Copy Markdown

Has this feature been removed from latest Mapbox navigation versions (2.17.4)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Allow change of color for Navigation notification

4 participants