Allow default notification color setting via MapboxNavigationOptions#1899
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1899 +/- ##
============================================
- Coverage 35.07% 35.04% -0.03%
Complexity 1060 1060
============================================
Files 261 261
Lines 8839 8848 +9
Branches 667 667
============================================
+ Hits 3100 3101 +1
- Misses 5467 5475 +8
Partials 272 272 |
Guardiola31337
approved these changes
Apr 18, 2019
|
Has this feature been removed from latest Mapbox navigation versions (2.17.4)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1527
bug,feature,new API(s),SEMVER, etc.)Goal
Allow developers to still utilize our default
MapboxNavigationNotification, but adjust the color to the theme of their application.Implementation
A
@ColorRes intadded to theMapboxNavigationOptionsthat is then consumed by the notification.Screenshots or Gifs
Testing
Please describe the manual tests that you ran to verify your changes
Checklist