Skip to content

Added check for legs to route refresh#1916

Merged
devotaaabel merged 2 commits into
masterfrom
devota-fix-route-refresh-npe
May 1, 2019
Merged

Added check for legs to route refresh#1916
devotaaabel merged 2 commits into
masterfrom
devota-fix-route-refresh-npe

Conversation

@devotaaabel
Copy link
Copy Markdown
Contributor

@devotaaabel devotaaabel commented Apr 29, 2019

Description

Fixed NPE reported by customer.

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

The directions refresh API now sends no legs when the map matching request fails. This PR accounts for those responses.

Implementation

This was fixed with a null check.

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed)
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@devotaaabel devotaaabel self-assigned this Apr 29, 2019
@devotaaabel devotaaabel added this to the v0.37.0 milestone Apr 29, 2019
@devotaaabel devotaaabel changed the title Added check for legs Added check for legs to route refresh Apr 29, 2019
Copy link
Copy Markdown
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devotaaabel thanks for running with this fix. Can we add a unit test for the new condition as well? Thanks!

@devotaaabel devotaaabel force-pushed the devota-fix-route-refresh-npe branch from d423ac8 to bb73112 Compare May 1, 2019 17:01
@devotaaabel devotaaabel force-pushed the devota-fix-route-refresh-npe branch from bb73112 to 486483d Compare May 1, 2019 17:11
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 1, 2019

Codecov Report

Merging #1916 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1916      +/-   ##
============================================
+ Coverage      36.3%   36.35%   +0.04%     
- Complexity     1086     1090       +4     
============================================
  Files           261      261              
  Lines          8874     8874              
  Branches        668      668              
============================================
+ Hits           3222     3226       +4     
+ Misses         5361     5357       -4     
  Partials        291      291

@danesfeder danesfeder mentioned this pull request May 1, 2019
11 tasks
Copy link
Copy Markdown
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback @devotaaabel 🚢

@devotaaabel devotaaabel merged commit 22dc9b9 into master May 1, 2019
@devotaaabel devotaaabel deleted the devota-fix-route-refresh-npe branch May 1, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants