Added check for legs to route refresh#1916
Merged
Merged
Conversation
danesfeder
reviewed
Apr 30, 2019
Contributor
danesfeder
left a comment
There was a problem hiding this comment.
@devotaaabel thanks for running with this fix. Can we add a unit test for the new condition as well? Thanks!
d423ac8 to
bb73112
Compare
bb73112 to
486483d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
============================================
+ Coverage 36.3% 36.35% +0.04%
- Complexity 1086 1090 +4
============================================
Files 261 261
Lines 8874 8874
Branches 668 668
============================================
+ Hits 3222 3226 +4
+ Misses 5361 5357 -4
Partials 291 291 |
danesfeder
approved these changes
May 1, 2019
Contributor
danesfeder
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @devotaaabel 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed NPE reported by customer.
bug,feature,new API(s),SEMVER, etc.)Goal
The directions refresh API now sends no legs when the map matching request fails. This PR accounts for those responses.
Implementation
This was fixed with a null check.
Testing
SNAPSHOTupstream dependencies if needed)Checklist