Skip to content

ReRoute fix#2518

Merged
korshaknn merged 2 commits into
masterfrom
knn-re-route-fix
Feb 28, 2020
Merged

ReRoute fix#2518
korshaknn merged 2 commits into
masterfrom
knn-re-route-fix

Conversation

@korshaknn
Copy link
Copy Markdown
Contributor

Description

Fixed bearings list on reRoute
Added tests for reRoute
Fixed flaky RemoveTilesTaslTest

closes #2501

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Please describe the PR goals. Just the stuff needed to implement the fix / feature and a simple rationale. It could contain many check points if needed

Implementation

Please include all the relevant things implemented and also rationale, clarifications / disclaimers etc. related to the approach used. It could be as self code companion comments

Screenshots or Gifs

Please include all the media files to give some context about what's being implemented or fixed. It's not mandatory to upload screenshots or gifs, but for most of the cases it becomes really handy to get into the scope of the feature / bug being fixed and also it's REALLY useful for UI related PRs screenshot gif

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@korshaknn korshaknn added the bug Defect to be fixed. label Feb 27, 2020
@korshaknn korshaknn added this to the v1.0.0 milestone Feb 27, 2020
@korshaknn korshaknn self-assigned this Feb 27, 2020
Copy link
Copy Markdown
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments (not blocking the PR).

Thanks for the quick fix @korshaknn 🚀

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 28, 2020

Codecov Report

Merging #2518 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2518   +/-   ##
========================================
  Coverage      29.1%   29.1%           
  Complexity     1057    1057           
========================================
  Files           281     281           
  Lines         10710   10710           
  Branches        839     839           
========================================
  Hits           3117    3117           
  Misses         7257    7257           
  Partials        336     336

Copy link
Copy Markdown

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@korshaknn korshaknn merged commit a544e77 into master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexOutOfBounds when rerouting

4 participants